Wikimedia
EventBusHooks::onArticleRevisionVisibilitySet should not create global functions
In the mediawiki/extensions/EventBus
code repository, there's a class called EventBusHooks
, that has a function, onArticleRevisionVisibilitySet
, which likely unintentionally creates new global functions.
In PHP, creating a function inside a class static function actually creates a global function (unlike JavaScript). https://3v4l.org/7tNtb
This should be switched to having private static helper functions instead of creating new global functions.
You are expected to provide a patch in Wikimedia Gerrit. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit.
Task tags
Students who completed this task
Phantom42