Wikimedia

LDAP based login is broken in Pywikibot because lgdomain is not set

Couldn't figure out why core didn't work on my wiki with LDAP login. After some debugging I found out that lgdomain doesn't seem to be set anywhere at all. See https://www.mediawiki.org/w/api.php?action=help&modules=login|query+info

If I just hardcode login_request["lgdomain"] = "mydomain" in api.py, it magically works. The login logic should look in the family file if self.ldapDomain is set and if that's the case include it in the request.

Pywikibot is a Python-based framework to write bots for MediaWiki. See https://www.mediawiki.org/wiki/Manual:Pywikibot for more information, and https://www.mediawiki.org/wiki/Manual:Pywikibot/PAWS for a short online interactive tutorial. Patches can be submitted via Gerrit (you need a MediaWiki.org account). More documentation on Gerrit can be found at https://www.mediawiki.org/wiki/Manual:Pywikibot/Gerrit. After you have successfully claimed this task on this site please do use the task in Phabricator for communication instead of this site. This allows more PWB developers to be reached! General development questions can be asked on the Pywikibot mailing list at https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l and the #pywikibot IRC channel (see https://www.mediawiki.org/wiki/MediaWiki_on_IRC).

Task tags

  • python
  • login
  • pywikibot
  • ldap

Students who completed this task

Phantom42

Task type

  • code Code
close

2016