MetaBrainz Foundation

Fix JS on MusicBrainz to eliminate unused variables

We use a tool called ESLint to find problems in our JavaScript code and ensure it has a consistent style. ESLint is configured to use "rules" which each check for a different problem in the code.

This task requires you to fix all problems detected by the no-unused-vars rule.

To invoke this rule and find a list of such problems, you must first navigate to the git checkout of musicbrainz-server in your terminal, and run:

./script/check_eslint_rule 'no-unused-vars: error' root/

The output will tell you which files it detected problems in, including line numbers, alongside a description of the actual issue on each line.

In this case, you'll need to check that the variables detected by eslint are indeed unused, and if they are you should get rid of them. Unused variables can be imports (left behind by accident after they stopped being needed), function arguments that a function no longer uses, or even just variables that get assigned a value, but are never actually used in the code afterwards.

To complete the task, submit a pull request to our GitHub repository with a proper description mentioning the specific rule, and respond to any suggestions and requests by the MusicBrainz developers until the pull request is approved (you do not need to wait until it gets merged).

Task tags

  • musicbrainz
  • javascript
  • eslint

Students who completed this task

ruinername

Task type

  • code Code
close

2019