Fix JS functions on MusicBrainz to either always or never specify values for return statements
We use a tool called ESLint to find problems in our JavaScript code and ensure it has a consistent style. ESLint is configured to use "rules" which each check for a different problem in the code.
This task requires you to fix all problems detected by the consistent-return rule.
To invoke this rule and find a list of such problems, you must first navigate to the git checkout of musicbrainz-server in your terminal, and run:
./script/check_eslint_rule 'consistent-return: error' root/
The output will tell you which files it detected problems in, including line numbers, alongside a description of the actual issue on each line.
In this case, you'll need to ensure that all code paths in the same function either all return
an explicit value, or all return no value (undefined
). For example, we shouldn't have a case where a function returns true if a condition applies, but returns nothing otherwise.
To complete the task, submit a pull request to our GitHub repository with a proper description mentioning the specific rule, and respond to any suggestions and requests by the MusicBrainz developers until the pull request is approved (you do not need to wait until it gets merged).