MetaBrainz Foundation

Fix JSX on MusicBrainz to have a consistent event handler naming convention

We use a tool called ESLint to find problems in our JavaScript code and ensure it has a consistent style. ESLint is configured to use "rules" which each check for a different problem in the code.

This task requires you to fix all problems detected by the react/jsx-handler-names rule.

To invoke this rule and find a list of such problems, you must first navigate to the git checkout of musicbrainz-server in your terminal, and run:

./script/check_eslint_rule 'react/jsx-handler-names: warn' root/

The output will tell you which files it detected problems in, including line numbers, alongside a description of the actual issue on each line.

In this case, you'll need to ensure all event handler functions are named so that they start with the word "handle." This ensures consistency and makes functions that handle events easy to identify by their name.

To complete the task, submit a pull request to our GitHub repository with a proper description mentioning the specific rule, and respond to any suggestions and requests by the MusicBrainz developers until the pull request is approved (you do not need to wait until it gets merged).

Task tags

  • musicbrainz
  • javascript
  • eslint

Students who completed this task

jbs1

Task type

  • code Code
close

2019