Wikimedia
Remove unchecked calls to Title::getTalkPage from the Favorites extension
All calls to Title::getTalkPage
must either be changed to getTalkPageIfDefined
, or they must first check canHaveTalkPage()
. These checks can be omitted only for the User namespace, since user pages can always have talk pages. (Note that calls to User::getTalkPage
do not need checks, since users can always have talk pages.)
Files to evaluate in the code repository mediawiki/extensions/Favorites
:
- https://github.com/wikimedia/mediawiki-extensions-Favorites/blob/master/FavoritelistEditor.php
- https://github.com/wikimedia/mediawiki-extensions-Favorites/blob/master/SpecialFavoritelist.php
You are expected to provide a patch in Wikimedia Gerrit (not in Github!). See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit.
Task tags
Students who completed this task
terppa05