Wikimedia

Remove unchecked calls to Title::getTalkPage from the EditSubpages extension

All calls to Title::getTalkPage must either be changed to getTalkPageIfDefined, or they must first check canHaveTalkPage(). These checks can be omitted only for the User namespace, since user pages can always have talk pages. (Note that calls to User::getTalkPage do not need checks, since users can always have talk pages.)

Files to evaluate in the code repository mediawiki/extensions/EditSubpages:

https://github.com/wikimedia/mediawiki-extensions-EditSubpages/blob/master/ExtEditSubpages.class.php

You are expected to provide a patch in Wikimedia Gerrit (not in Github!). See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit.

Task tags

  • mediawiki
  • php

Students who completed this task

arcaynia

Task type

  • code Code
close

2018