Wikimedia

Download icon in the MinervaNeue skin is causing invalid HTML

MediaWiki has an extension called MobileFrontend and a skin called Minerva-Neue. You can see them in action when you go to (for example) https://m.mediawiki.org/ instead of https://www.mediawiki.org/ (note the "m" instead of "www" in the URL).

This is about the file resources/skins.minerva.scripts/DownloadIcon.js in the Git repository mediawiki/skins/MinervaNeue.

The download icon li element is wrapped in <div class="view-border-box"> causing the page output to be invalid HTML.

= Developer notes

Since we have

View.prototype.tagName = 'div'

We can do

DownloadIcon.prototype.tagName = 'li''

You are expected to provide a patch in Wikimedia Gerrit. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit.

Task tags

  • javascript
  • css

Students who completed this task

Jan Rosa

Task type

  • code Code
close

2018