Wikimedia

Make phan-taint-check-plugin support Hooks::runWithoutAbort in addition to Hooks::run

phan-taint-check-plugin is a plugin to the phan static analysis tool, which checks MediaWiki code for certain types of security errors. See https://github.com/wikimedia/Phan-Taint-Check-Plugin/blob/master/README.md for more details about the project.

Currently this code special cases calls to Hooks::run() but misses calls to the new Hooks::runWithoutAbort()

All that needs to be done, is on "src/MWVisitor.php" line 96 (in the mediawiki/tools/phan/SecurityCheckPlugin.git repo), instead of just \Hooks::run, it also needs to check for \Hooks::runWithoutAbort (This should be an extra case statement, that has no body, but just falls through to the \Hooks::run case).

You are expected to provide a patch in Wikimedia Gerrit. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit.

Task tags

  • security
  • static analysis

Students who completed this task

Phantom42

Task type

  • code Code
  • done_all Quality Assurance
close

2017