OpenMRS

Define a constants for string literal in FilterUtil

For lines: https://github.com/openmrs/openmrs-core/blob/master/web/src/main/java/org/openmrs/web/filter/util/FilterUtil.java#L99 https://github.com/openmrs/openmrs-core/blob/master/web/src/main/java/org/openmrs/web/filter/util/FilterUtil.java#L146 https://github.com/openmrs/openmrs-core/blob/master/web/src/main/java/org/openmrs/web/filter/util/FilterUtil.java#L227 replace the "Error while closing the database" string literal with a constant. Background Information: String literals should not be duplicated Duplicated string literals makes the process of refactoring error-prone, since you must be sure to update all occurrences. On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Task tags

  • coding

Students who completed this task

Dawid Wąsala

Task type

  • code Code
close

2017