Wikimedia

Fix wrong newsletter URL class in Newsletter extension Echo presentation model

This task is about the Newsletter extension.

https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/master/includes/Echo/BaseNewsletterPresentationModel.php#L18 have our function defined as:

    protected function getSpecialNewsletterUrl(){
        return SpecialPage::getTitleFor( 'Newsletter', $this->getNewsletterId() )->getFullURL();
    }

and points to Special:Newsletter/id/ but it should redirect to Newsletter:NewsletterName - which is the current Newsletter base URL.

You might need to recreate a notification in your local instance to test this out! Might need minor reworks on the existing Echo notifications after this one too.

Task tags

  • php
  • newsletter

Students who completed this task

Justin Du

Task type

  • code Code
close

2016