CCExtractor Development

Task for Danila Fedorin : Split your PR in smaller chunks

This PR https://github.com/CCExtractor/ccextractor/pull/480

Is quite reasonable. Only problem is that it's too big to merge it in one go (affects too many files).

It should be split in "themes", such as one PR for changes in params.c and friends, one for utils.c, and so on. For course changing utils.c means that the prototypes change, and so the calls to the functions there. That's OK, each PR needs to be self contained (don't depend on others to keep the code buildable, since that defeats the purpose).

You can start submitting just one PR, wait for it to be merged, then send the next... that will make it easy to be in sync and keep things tested and tidy.

Task tags

  • pr
  • refactor
  • consistency

Students who completed this task

Danila Fedorin

Task type

  • code Code
  • done_all Quality Assurance
close

2016