Wikimedia

Add MinusX support to two MediaWiki extensions (#1)

To improve our code quality and security, we want to reject non-executable files which have execute bits (basically marks that tell the operating system it can run this file) set via a build check. In Wikimedia we have a utility called MinusX for this.

So we need to add MinusX to most MediaWiki extensions and PHP library repositories.

https://gerrit.wikimedia.org/r/#/c/377710/ is an example change for MediaWiki's Scribunto extension which shows what needs to be done.

Your task is to add MinusX to the two code repositories listed below. You are expected to provide two patches in Wikimedia Gerrit. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit. Also make sure that your commit message says Bug: T175794 as the last line. Once you have added your two patches to Wikimedia Gerrit, go to https://phabricator.wikimedia.org/T175794 and click "Edit Task" in the upper right corner. Then add the line - Patch for review: followed by the link to your Gerrit patch to the corresponding line for that repository. See the Phabricator Help if you do not have an account on Wikimedia Phabricator yet!

  • extensions/CommunityTwitter
  • extensions/CreateUserPage

Task tags

  • code quality
  • json

Students who completed this task

Albert Wolszon

Task type

  • code Code
  • done_all Quality Assurance
close

2017